Eric Dumazet
bc5fc4a609
net: add annotations on hh->hh_len lockless accesses
[ Upstream commit c305c6ae79e2ce20c22660ceda94f0d86d639a82 ]
KCSAN reported a data-race [1]
While we can use READ_ONCE() on the read sides,
we need to make sure hh->hh_len is written last.
[1]
BUG: KCSAN: data-race in eth_header_cache / neigh_resolve_output
write to 0xffff8880b9dedcb8 of 4 bytes by task 29760 on cpu 0:
eth_header_cache+0xa9/0xd0 net/ethernet/eth.c:247
neigh_hh_init net/core/neighbour.c:1463 [inline]
neigh_resolve_output net/core/neighbour.c:1480 [inline]
neigh_resolve_output+0x415/0x470 net/core/neighbour.c:1470
neigh_output include/net/neighbour.h:511 [inline]
ip6_finish_output2+0x7a2/0xec0 net/ipv6/ip6_output.c:116
__ip6_finish_output net/ipv6/ip6_output.c:142 [inline]
__ip6_finish_output+0x2d7/0x330 net/ipv6/ip6_output.c:127
ip6_finish_output+0x41/0x160 net/ipv6/ip6_output.c:152
NF_HOOK_COND include/linux/netfilter.h:294 [inline]
ip6_output+0xf2/0x280 net/ipv6/ip6_output.c:175
dst_output include/net/dst.h:436 [inline]
NF_HOOK include/linux/netfilter.h:305 [inline]
ndisc_send_skb+0x459/0x5f0 net/ipv6/ndisc.c:505
ndisc_send_ns+0x207/0x430 net/ipv6/ndisc.c:647
rt6_probe_deferred+0x98/0xf0 net/ipv6/route.c:615
process_one_work+0x3d4/0x890 kernel/workqueue.c:2269
worker_thread+0xa0/0x800 kernel/workqueue.c:2415
kthread+0x1d4/0x200 drivers/block/aoe/aoecmd.c:1253
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
read to 0xffff8880b9dedcb8 of 4 bytes by task 29572 on cpu 1:
neigh_resolve_output net/core/neighbour.c:1479 [inline]
neigh_resolve_output+0x113/0x470 net/core/neighbour.c:1470
neigh_output include/net/neighbour.h:511 [inline]
ip6_finish_output2+0x7a2/0xec0 net/ipv6/ip6_output.c:116
__ip6_finish_output net/ipv6/ip6_output.c:142 [inline]
__ip6_finish_output+0x2d7/0x330 net/ipv6/ip6_output.c:127
ip6_finish_output+0x41/0x160 net/ipv6/ip6_output.c:152
NF_HOOK_COND include/linux/netfilter.h:294 [inline]
ip6_output+0xf2/0x280 net/ipv6/ip6_output.c:175
dst_output include/net/dst.h:436 [inline]
NF_HOOK include/linux/netfilter.h:305 [inline]
ndisc_send_skb+0x459/0x5f0 net/ipv6/ndisc.c:505
ndisc_send_ns+0x207/0x430 net/ipv6/ndisc.c:647
rt6_probe_deferred+0x98/0xf0 net/ipv6/route.c:615
process_one_work+0x3d4/0x890 kernel/workqueue.c:2269
worker_thread+0xa0/0x800 kernel/workqueue.c:2415
kthread+0x1d4/0x200 drivers/block/aoe/aoecmd.c:1253
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 29572 Comm: kworker/1:4 Not tainted 5.4.0-rc6+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events rt6_probe_deferred
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-01-09 10:19:09 +01:00
..
2020-01-09 10:19:04 +01:00
2019-12-13 08:52:52 +01:00
2020-01-09 10:19:01 +01:00
2019-12-01 09:16:41 +01:00
2019-12-05 09:21:04 +01:00
2020-01-09 10:18:58 +01:00
2020-01-09 10:19:04 +01:00
2019-12-13 08:51:23 +01:00
2020-01-04 19:13:12 +01:00
2019-12-31 16:35:23 +01:00
2020-01-04 19:12:57 +01:00
2020-01-04 19:12:45 +01:00
2019-12-31 16:36:01 +01:00
2019-12-17 20:35:00 +01:00
2019-12-31 16:36:13 +01:00
2020-01-09 10:19:03 +01:00
2020-01-04 19:12:38 +01:00
2019-12-21 10:57:38 +01:00
2019-12-31 16:35:58 +01:00
2019-12-31 16:35:11 +01:00
2020-01-09 10:19:09 +01:00
2019-12-17 20:35:52 +01:00
2019-12-31 16:35:55 +01:00
2020-01-09 10:19:01 +01:00
2020-01-09 10:19:07 +01:00
2020-01-09 10:19:03 +01:00
2019-11-24 08:21:01 +01:00
2019-12-31 16:36:24 +01:00
2019-12-13 08:51:57 +01:00
2020-01-09 10:18:55 +01:00
2020-01-09 10:18:58 +01:00
2020-01-04 19:12:36 +01:00
2020-01-04 19:12:38 +01:00
2020-01-04 19:12:52 +01:00
2019-12-17 20:34:33 +01:00
2020-01-04 19:12:43 +01:00
2019-11-24 08:20:52 +01:00
2019-12-01 09:16:37 +01:00
2020-01-04 19:13:17 +01:00
2020-01-09 10:18:57 +01:00
2020-01-09 10:19:06 +01:00
2019-12-05 09:20:29 +01:00
2019-12-01 09:16:57 +01:00
2019-12-13 08:51:56 +01:00
2019-12-31 16:36:36 +01:00
2019-12-17 20:34:42 +01:00
2020-01-09 10:19:09 +01:00
2019-12-13 08:51:03 +01:00
2019-12-01 09:17:13 +01:00
2020-01-04 19:13:00 +01:00
2020-01-09 10:18:54 +01:00
2019-12-31 16:35:37 +01:00
2019-12-17 20:36:04 +01:00
2019-12-31 16:36:01 +01:00
2020-01-04 19:12:55 +01:00
2019-12-31 16:35:30 +01:00
2020-01-04 19:13:45 +01:00
2020-01-09 10:19:04 +01:00
2019-12-17 20:35:37 +01:00
2020-01-04 19:13:35 +01:00
2019-12-05 09:21:29 +01:00
2020-01-09 10:19:05 +01:00
2019-11-24 08:20:29 +01:00
2019-12-05 09:19:36 +01:00
2019-12-21 10:57:30 +01:00
2019-12-17 20:35:43 +01:00
2020-01-04 19:13:14 +01:00
2020-01-09 10:19:07 +01:00
2019-12-13 08:51:54 +01:00
2019-12-13 08:52:29 +01:00
2019-12-31 16:35:55 +01:00
2020-01-04 19:13:45 +01:00
2019-12-31 16:36:26 +01:00
2020-01-04 19:13:06 +01:00
2019-12-13 08:52:50 +01:00
2019-12-05 09:21:27 +01:00
2020-01-09 10:19:08 +01:00
2020-01-09 10:18:57 +01:00
2019-12-21 10:57:37 +01:00
2020-01-04 19:13:36 +01:00
2019-12-17 20:35:17 +01:00
2019-12-17 20:34:43 +01:00
2019-12-01 09:16:22 +01:00
2020-01-04 19:13:01 +01:00
2020-01-09 10:18:58 +01:00