Edwin Peer bb7addea77
net: watchdog: hold device global xmit lock during tx disable ...
commit 3aa6bce9af0e25b735c9c1263739a5639a336ae8 upstream.
Prevent netif_tx_disable() running concurrently with dev_watchdog() by
taking the device global xmit lock. Otherwise, the recommended:
netif_carrier_off(dev);
netif_tx_disable(dev);
driver shutdown sequence can happen after the watchdog has already
checked carrier, resulting in possible false alarms. This is because
netif_tx_lock() only sets the frozen bit without maintaining the locks
on the individual queues.
Fixes: c3f26a269cedwin.peer@broadcom.com >
Reviewed-by: Jakub Kicinski <kuba@kernel.org >
Signed-off-by: David S. Miller <davem@davemloft.net >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2021-02-23 15:00:58 +01:00
2020-11-18 19:18:42 +01:00
2020-04-02 15:28:16 +02:00
2020-04-29 16:31:24 +02:00
2020-01-27 14:50:42 +01:00
2019-12-17 20:35:45 +01:00
2020-06-03 08:19:11 +02:00
2020-10-01 13:14:28 +02:00
2020-11-05 11:08:34 +01:00
2020-12-30 11:25:45 +01:00
2020-01-27 14:51:19 +01:00
2020-02-01 09:37:10 +00:00
2020-06-30 23:17:12 -04:00
2020-01-23 08:21:39 +01:00
2021-01-30 13:32:11 +01:00
2020-12-11 13:25:03 +01:00
2021-02-13 13:51:14 +01:00
2020-11-05 11:08:40 +01:00
2021-01-19 18:22:36 +01:00
2020-01-09 10:19:01 +01:00
2019-12-13 08:52:59 +01:00
2021-02-13 13:51:15 +01:00
2020-08-19 08:15:05 +02:00
2020-06-25 15:33:02 +02:00
2020-04-29 16:31:17 +02:00
2020-04-29 16:31:17 +02:00
2020-04-23 10:30:12 +02:00
2020-12-30 11:25:39 +01:00
2020-09-09 19:04:31 +02:00
2020-07-22 09:32:00 +02:00
2020-07-22 09:32:00 +02:00
2021-01-30 13:32:11 +01:00
2020-12-30 11:25:40 +01:00
2021-01-23 15:49:55 +01:00
2020-12-30 11:25:40 +01:00
2019-12-31 16:36:22 +01:00
2020-11-05 11:08:35 +01:00
2020-10-01 13:14:28 +02:00
2020-04-17 10:48:45 +02:00
2020-07-29 10:16:59 +02:00
2020-03-20 11:55:58 +01:00
2021-01-23 15:49:55 +01:00
2020-02-24 08:34:44 +01:00
2020-09-03 11:24:23 +02:00
2021-02-10 09:21:06 +01:00
2020-06-25 15:33:02 +02:00
2020-02-11 04:34:08 -08:00
2020-07-16 08:17:27 +02:00
2020-10-14 10:31:21 +02:00
2021-01-30 13:32:13 +01:00
2021-01-06 14:44:58 +01:00
2021-01-06 14:44:58 +01:00
2020-11-05 11:08:35 +01:00
2021-01-30 13:32:12 +01:00
2020-06-25 15:33:07 +02:00
2020-09-09 19:04:22 +02:00
2020-11-05 11:08:54 +01:00
2020-01-04 19:13:32 +01:00
2019-12-17 20:35:45 +01:00
2021-02-10 09:21:08 +01:00
2020-08-11 15:32:33 +02:00
2020-09-23 12:10:59 +02:00
2020-05-10 10:30:12 +02:00
2020-01-12 12:17:25 +01:00
2020-07-22 09:32:00 +02:00
2020-03-18 07:14:11 +01:00
2021-02-03 23:23:26 +01:00
2020-02-28 16:38:59 +01:00
2020-07-29 10:16:57 +02:00
2020-05-10 10:30:11 +02:00
2020-04-17 10:48:41 +02:00
2019-12-31 16:35:23 +01:00
2020-08-21 11:05:28 +02:00
2020-02-28 16:38:50 +01:00
2019-12-13 08:52:43 +01:00
2020-07-16 08:17:26 +02:00
2021-01-09 13:43:48 +01:00
2019-12-13 08:52:43 +01:00
2020-04-23 10:30:24 +02:00
2020-06-22 09:05:15 +02:00
2020-10-14 10:31:26 +02:00
2021-02-13 13:51:13 +01:00
2021-02-07 14:48:38 +01:00
2020-06-22 09:05:04 +02:00
2020-04-29 16:31:19 +02:00
2020-10-01 13:14:54 +02:00
2020-01-04 19:13:15 +01:00
2020-02-24 08:34:46 +01:00
2020-09-09 19:04:28 +02:00
2020-01-23 08:21:29 +01:00
2020-02-11 04:34:18 -08:00
2020-01-29 16:43:27 +01:00
2020-01-29 16:43:27 +01:00
2019-12-31 16:35:38 +01:00
2020-11-10 12:35:58 +01:00
2020-10-07 08:00:08 +02:00
2020-07-29 10:16:52 +02:00
2021-02-10 09:21:07 +01:00
2021-02-23 15:00:58 +01:00
2020-11-18 19:18:44 +01:00
2020-11-18 19:18:44 +01:00
2020-12-02 08:48:07 +01:00
2020-10-01 13:14:41 +02:00
2020-10-07 08:00:08 +02:00
2020-04-13 10:45:06 +02:00
2020-04-17 10:48:45 +02:00
2021-01-06 14:45:00 +01:00
2020-10-29 09:55:15 +01:00
2020-10-30 10:38:20 +01:00
2020-05-27 17:37:35 +02:00
2020-03-25 08:06:13 +01:00
2020-06-22 09:05:25 +02:00
2020-04-17 10:48:46 +02:00
2020-10-01 13:14:40 +02:00
2020-04-23 10:30:20 +02:00
2020-02-11 04:34:11 -08:00
2020-01-27 14:50:27 +01:00
2020-03-18 07:14:17 +01:00
2020-01-27 14:50:26 +01:00
2020-05-20 08:18:45 +02:00
2020-01-17 19:46:55 +01:00
2020-01-04 19:13:35 +01:00
2020-11-18 19:18:52 +01:00
2020-07-22 09:32:13 +02:00
2021-01-12 20:10:17 +01:00
2019-12-13 08:52:28 +01:00
2020-01-04 19:12:53 +01:00
2019-12-17 20:35:17 +01:00
2020-08-07 09:36:21 +02:00
2020-02-24 08:34:46 +01:00
2020-01-27 14:50:37 +01:00
2021-01-30 13:32:12 +01:00
2020-12-30 11:26:06 +01:00
2020-04-02 15:28:22 +02:00
2020-12-30 11:26:01 +01:00
2020-10-01 13:14:30 +02:00
2020-06-22 09:05:03 +02:00
2020-01-27 14:51:05 +01:00
2021-01-23 15:49:56 +01:00
2021-02-13 13:51:15 +01:00
2020-04-17 10:48:43 +02:00
2020-04-23 10:30:19 +02:00
2020-01-27 14:50:22 +01:00
2020-07-31 18:37:48 +02:00
2020-11-18 19:18:40 +01:00
2019-12-21 10:57:17 +01:00
2020-01-23 08:21:32 +01:00
2020-12-30 11:26:01 +01:00
2020-08-19 08:14:47 +02:00
2020-12-11 13:25:01 +01:00
2020-09-09 19:04:29 +02:00
2020-12-30 11:25:42 +01:00
2020-06-30 23:17:00 -04:00
2020-10-07 08:00:05 +02:00
2020-04-29 16:31:27 +02:00
2020-04-02 15:28:23 +02:00
2020-08-11 15:32:34 +02:00
bb7addea77