Files
kernel/include/linux
Anssi Hannula f129ea6d1e HID: fix a lockup regression when using force feedback on a PID device
Commit 8006479c9b introduced a spinlock in
input_dev->event_lock, which is locked when handling input events.
However, the hid-pidff driver sleeps when handling events as it waits for
reports being sent to the device before changing the report contents
again.
This causes a system lockup when trying to use force feedback with a PID
device, a regression introduced in 2.6.24 and 2.6.23.15.

Fix it by extracting the raw report data from struct hid_report
immediately when hid_submit_report() is called, therefore allowing
drivers to change the contents of struct hid_report immediately without
affecting the already-queued transfer.

In hid-pidff, re-add the removed usbhid_wait_io() to
pidff_erase_effect() instead, to prevent a full report queue from causing
the submission to fail, thus not freeing up device memory.
pidff_erase_effect() is not called while dev->event_lock is held.

Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
2008-10-14 23:51:02 +02:00
..
2008-09-12 16:30:20 -07:00
2008-10-09 08:56:22 +02:00
2008-10-10 13:37:12 +01:00
2008-10-12 12:05:55 +02:00
2008-10-08 19:44:18 -04:00
2008-09-22 07:29:31 +01:00
2008-10-14 23:51:02 +02:00
2008-10-09 11:59:55 -07:00
2008-09-22 21:28:11 -07:00
2008-10-07 15:34:37 -07:00
2008-10-12 11:44:37 -07:00
2008-10-13 09:47:43 +11:00
2008-10-09 08:56:06 +02:00
2008-10-14 23:50:47 +02:00
2008-10-01 07:03:24 -07:00
2008-10-08 16:38:41 -07:00
2008-09-16 19:35:05 -07:00
2008-10-02 15:53:13 -07:00
2008-09-22 19:51:15 -07:00
2008-10-12 12:37:32 +02:00
2008-10-07 14:22:33 -07:00
2008-10-07 14:43:06 -07:00
2008-10-13 09:51:40 -07:00